GitLab

Revert "Merge branch 'ajwalker/after_script-kamil' into 'master'"

See merge request gitlab-org/gitlab-runner!2469

This reverts commit 411b98f3, reversing
changes made to 689cf710.

Allow runner to archive cache on failure

See merge request gitlab-org/gitlab-runner!2416

Stylistic changes based on review

`cache:when` is used to cache on job failure, despite the failure.

`cache:when` can be set to one of the following values:

1. `on_success` - upload artifacts only when the job succeeds.
   This is the default.
2. `on_failure` - upload artifacts only when the job fails.
3. `always` - upload artifacts regardless of the job status.

Doc `cleanup_file_variables` for custom executor

See merge request gitlab-org/gitlab-runner!2455

Report Kubernetes pods' conditions when they're pending

Closes #4569

See merge request gitlab-org/gitlab-runner!2434

Merge branch '27068-metrics-specify-that-a-job-has-failed-succeeded-even-when-running-after_script-which-breaks' into 'master'

Detach runtime state/metric from CI_JOB_STATUS

Closes #27068

See merge request gitlab-org/gitlab-runner!2462

Ensure that for abort only abort is called

Closes #27056

See merge request gitlab-org/gitlab-runner!2463

Previously we would call `cancel()` on `abort()`
which in some implementations could result
in calling additional steps due to race condition.

The `abort()` is final, we don't need to `cancel()` before
as `abort()` in any case should take a precedence
in processing.

In https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27001 we had to
introduce a new step for the runner to execute at the end of the build
to clean up the file based variables from disk. We need to document this
step on the custom executor so that users are aware of it.

Run after_script for cancelled jobs

Closes #4843

See merge request gitlab-org/gitlab-runner!2443

Link Azure storage container docs

See merge request gitlab-org/gitlab-runner!2454

This may help reduce confusion, since an Azure container could be
confused with Docker container.

Update stretchr/testify library to fix flaky test

Closes #27037

See merge request gitlab-org/gitlab-runner!2450

Update calls for SkipIntegrationTests to not return

Closes #25553

See merge request gitlab-org/gitlab-runner!2065

SkipIntegrationTests has t.Skip inside so there's no need for the condition.

`TestBuildsHelperCollect` panics from time to time for example
https://gitlab.com/gitlab-org/gitlab-runner/-/jobs/769151804 because, we
are using
[`Eventually`](https://gitlab.com/gitlab-org/gitlab-runner/-/blob/2cf2f6eb9ab23d3445dd5297ff539bf571a614fb/vendor/github.com/stretchr/testify/assert/assertions.go#L1473-1498)
and there is a bug where it [tries to write to a
channel](https://gitlab.com/gitlab-org/gitlab-runner/-/blob/2cf2f6eb9ab23d3445dd5297ff539bf571a614fb/vendor/github.com/stretchr/testify/assert/assertions.go#L1494)
that is closed by a
[defer](https://gitlab.com/gitlab-org/gitlab-runner/-/blob/2cf2f6eb9ab23d3445dd5297ff539bf571a614fb/vendor/github.com/stretchr/testify/assert/assertions.go#L1483).
Since the write is in it's own goroutine it can be the case that the
goroutine is schedule **after** the function returns which closes the
channel. Newer version of testify aren't effected by this because
[`Eventually`](https://github.com/stretchr/testify/blob/54d05a4e18440fb0a44989ab910f347eac4a131f/assert/assertions.go#L1635-L1662)
was re-written and fixed in
https://github.com/stretchr/testify/pull/808.

closes https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27037

Docs: Removed extra notes

See merge request gitlab-org/gitlab-runner!2440

Related to: https://gitlab.com/gitlab-org/technical-writing/-/issues/255

Test more executors in TestAskRunnerOverrideDefaults

See merge request gitlab-org/gitlab-runner!2406

Removed many of the notes

See merge request gitlab-org/gitlab-runner!2439

Fix typo in k8s read_only config flag documentation

See merge request gitlab-org/gitlab-runner!2441

Use google driver for examples

See merge request gitlab-org/gitlab-runner!2442

In https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/2417 and
https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/2438 we
started to use `google` as a driver exclusively but miss 1 configuration
example. Update it to use the `google` driver to be consistent.